Skip to content

[feature/corporate-design] Corporate Color + UI Refinements #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hosy merged 7 commits into from
Jan 25, 2021
Merged

[feature/corporate-design] Corporate Color + UI Refinements #870

hosy merged 7 commits into from
Jan 25, 2021

Conversation

@hosy
Copy link
Collaborator

@hosy hosy commented Jan 14, 2021

Description

The corporate color of the UI themes was updated and furthermore some colors was adopted for a better contrast.
Furthermore the following images was updated with the new corporate color values:

  • Splash screen background image
  • App Icon (regular and EMM-App)

This PR includes also some UI Refinements:

  • Alignment of the More button in the navigation bar and the Select button in sort bar with the position of the More button in the item cell
  • Moved Sort Popover some pixels to the left to prevent to see some pixels from item cell icons in the background
  • Aligned Sort Direction Arrow in Sort Popover to the right
  • Fixed unselected tab bar items contrast

Related Issue

#860

Motivation and Context

Update UI to the correct corporate color and refine UI design

How Has This Been Tested?

Screenshots (if appropriate):

Simulator Screen Shot - iPhone 12 - 2021-01-14 at 14 19 25

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@hosy
- updated corporate color in UI, splash background, app icons
de6db7f 
- changed some UI colors in light, contrast and dark UI
- fixed alignment of more button in navigation bar and select button in sort bar with item cell more button
- right aligned sort direction in sort method table view
@hosy hosy requested review from felix-schwarz and jesmrec January 14, 2021 13:26
@hosy hosy self-assigned this Jan 14, 2021
@hosy hosy added this to the 11.5.0-Current milestone Jan 14, 2021
@hosy hosy linked an issue Jan 14, 2021 that may be closed by this pull request
Icons not clear (when using the light Theme) #860
Closed
@jesmrec
Copy link
Contributor

jesmrec commented Jan 15, 2021

About the fixes done here:

Alignment of the More button in the navigation bar and the Select button in sort bar with the position of the More button in the item cell

👍

Moved Sort Popover some pixels to the left to prevent to see some pixels from item cell icons in the background

is it moved to the right, right?

Aligned Sort Direction Arrow in Sort Popover to the right

👍

Fixed unselected tab bar items contrast

👍

@jesmrec
Copy link
Contributor

jesmrec commented Jan 15, 2021

Some colors changed. Changes after appyling new themes or anything is missing? here are the changes:

  • Dark theme: blue color in sort menu
Before Current
Screen Shot 2021-01-15 at 12 33 37 Screen Shot 2021-01-15 at 12 27 24
  • Classic theme: blue color in sort menu
Before Current
Screen Shot 2021-01-15 at 12 34 15 Screen Shot 2021-01-15 at 12 30 25
  • Light theme: blue fonts in navigation, sort menu, multiselection menu, action card items and bottom bar selection items tuned to black.
Before Current
Screen Shot 2021-01-15 at 12 41 14 Screen Shot 2021-01-15 at 12 27 54
  • Contrast is not correct in downloads view (light & classic themes). Background should not be black

Screen Shot 2021-01-15 at 12 50 05

@hosy
Copy link
Collaborator Author

hosy commented Jan 15, 2021

@jesmrec all your findings are fixed!
Note: Light blue color might be changed after PR was approved.

@hosy
Merge branch 'milestone/11.5' into feature/corporate-design
5905db7 
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@jesmrec
Copy link
Contributor

jesmrec commented Jan 18, 2021

Everything fixed

Approved

@jesmrec jesmrec added the Approved by QA Approved by QA label Jan 18, 2021
@jesmrec jesmrec self-assigned this Jan 18, 2021
@hosy
Merge branch 'milestone/11.5' into feature/corporate-design
7d40373 
# Conflicts:
#	ios-sdk
#	ownCloudAppShared/Client/User Interface/SortBar.swift
@hosy hosy merged commit 12466c1 into milestone/11.5 Jan 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the feature/corporate-design branch January 25, 2021 20:48
@hosy hosy mentioned this pull request Jan 26, 2021
Closed
@jesmrec jesmrec mentioned this pull request Feb 3, 2021
Closed
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felix-schwarz felix-schwarz felix-schwarz approved these changes

@jesmrec jesmrec jesmrec approved these changes

Assignees

@hosy hosy

@jesmrec jesmrec

Labels

Approved by QA Approved by QA

Projects

None yet

Milestone

11.5.0

Development

Successfully merging this pull request may close these issues.

Icons not clear (when using the light Theme)

4 participants

@hosy @jesmrec @felix-schwarz